Skip to content

fix(os): pass pkgrepo state on unsupported os #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2019
Merged

fix(os): pass pkgrepo state on unsupported os #425

merged 1 commit into from
Aug 1, 2019

Conversation

noelmcloughlin
Copy link
Contributor

This PR avoids salt.pkgrepo state and/or rendering errors on MacOS/FreeBSD/Arch.

For example on Archlinux....

Data failed to compile:
----------
    Specified SLS salt.pkgrepo.arch in saltenv base is not available on the salt master or through a configured fileserver

@noelmcloughlin noelmcloughlin changed the title fix(os): pass state on unsupported os fix(os): pass pkgrepo state on unsupported os Jul 29, 2019
@noelmcloughlin noelmcloughlin mentioned this pull request Jul 29, 2019
Open
@noelmcloughlin
Copy link
Contributor Author

noelmcloughlin commented Jul 29, 2019 •
edited
Loading

Verified salt-formula on Archlinux.

----------
          ID: salt-pkgrepo-install-saltstack-norepo-arch
    Function: test.show_notification
      Result: True
     Comment: No official repository for Arch
     Started: 09:13:59.794797
    Duration: 0.247 ms

... etc ...

-------------
Succeeded: 12 (changed=5)
Failed:     0
-------------
Total states run:     12

@noelmcloughlin noelmcloughlin mentioned this pull request Jul 30, 2019
Merged
@noelmcloughlin
Copy link
Contributor Author

Verified salt-formula on MacOS.

----------
          ID: salt-pkgrepo-install-saltstack-norepo-macos
    Function: test.show_notification
      Result: True
     Comment: No official repository for MacOS
     Started: 09:13:59.794797
    Duration: 0.247 ms

... etc ...

@noelmcloughlin
Copy link
Contributor Author

One Travis CI failure is unrelated

@aboe76 aboe76 merged commit cb0219d into saltstack-formulas:master Aug 1, 2019
@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 0.58.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noelmcloughlin @saltstack-formulas-travis @aboe76