Skip to content

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented May 12, 2023

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from sarvex May 12, 2023 06:11
Comment on lines -214 to +223
prs_to_add = []

for pr in pr_data:
if (
not pr['isDraft'] and
reviewer_id in [req_rev['requestedReviewer']['id'] for req_rev in pr['reviewRequests']['nodes'] if req_rev['requestedReviewer']] and
project_id not in [proj_card['project']['id'] for proj_card in pr['projectCards']['nodes']]
):
prs_to_add.append(pr['id'])

return prs_to_add
return [
pr['id'] for pr in pr_data if (not pr['isDraft'] and reviewer_id in [
req_rev['requestedReviewer']['id']
for req_rev in pr['reviewRequests']['nodes']
if req_rev['requestedReviewer']
] and project_id not in [
proj_card['project']['id']
for proj_card in pr['projectCards']['nodes']
])
]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function filter_prs refactored with the following changes:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sarvex sarvex merged commit 64298e5 into main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant