Skip to content

#193 The out of scope variable, nonlocal #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 5, 2020

Conversation

diptangsu
Copy link
Contributor

I did not have to make many changes to what was already present with global. The link to the blog also is the same since it also explains nonlocal.

Also, this is something I did not understand, you can modify this bit before merging if at all this PR is merged.
image

@satwikkansal
Copy link
Owner

Hi @diptangsu

Example Id is any randomly generated UUID.

Regarding the example part, thanks for the work. I think it'd be better if we can add nonlocal snippet to the existing example (if you see there's a lot of redundancy in the explanation, which people don't usually like).

@satwikkansal
Copy link
Owner

I think it's enough to mention the nolocal keyword in the explanation with (probably) an example snippet

@diptangsu
Copy link
Contributor Author

Yes, I agree!
Let me change the original example to add the nonlocal part. I actually thought about it but I didn't know how you'd feel about me changing an existing example.

Also removed the extra entry from the main index.
@diptangsu
Copy link
Contributor Author

Tried my best to fit it in with the existing example. Let me know if you want me to change something.

@satwikkansal
Copy link
Owner

Hi @diptangsu

Thanks, there are a few minor change, but don't worry, I'll add those myself on top of your commit. Merging your PR for now.

@satwikkansal satwikkansal merged commit 7525e80 into satwikkansal:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants