-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix a syntax error and some spelling errors, improve typography #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a syntax error and some spelling errors, improve typography #72
Conversation
README.md
Outdated
@@ -1400,7 +1400,7 @@ Okay, now it's deleted :confused: | |||
+ `del x` doesn’t directly call `x.__del__()`. | |||
+ Whenever `del x` is encountered, Python decrements the reference count for `x` by one, and `x.__del__()` when x’s reference count reaches zero. | |||
+ In the second output snippet, `y.__del__()` was not called because the previous statement (`>>> y`) in the interactive interpreter created another reference to the same object, thus preventing the reference count to reach zero when `del y` was encountered. | |||
+ Calling `globals` caused the existing reference to be destroyed and hence we can see "Deleted!" being printed (finally!). | |||
+ Calling `globals` caused the existing reference to be destroyed and hence we can see “Deleted!” being printed (finally!). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of quotes replaced (" with “) in the PR. Is there any difference in the meanings of both the characters. The one you replace it with isn't a character typed by standard keyboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have the same meaning. These are the modern, better looking, more readable, English opening “
and closing ”
quotes. There are easily available – though not widely known – on modern keyboard layouts.
If you don’t like it though, I can discard that change from my PR.
(To be honest I was tempted to change from ...
to …
but at first I thought it was too many little changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have the same meaning. These are the modern, better looking, more readable, English opening “ and closing ” quotes. There are easily available – though not widely known – on modern keyboard layouts.
Interesting, I didn't knew that :)
If you don’t like it though, I can discard that change from my PR.
The thing is, they are not ASCII. And given the fact anyone can contribute to the project, it'd be quite tedious to maintain consistency for quotes in the future examples. I hope you understand...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I totally understand. :)
2c5fe64
to
2551b7c
Compare
I updated my branch :) |
@@ -2127,7 +2127,7 @@ Why did `Yo()._Yo__honey` worked? Only Indian readers would understand. | |||
|
|||
--- | |||
|
|||
## Section: Miscallaneous | |||
## Section: Miscellaneous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to update the TOC as well :)
README.md
Outdated
@@ -2369,7 +2369,7 @@ If you have any wtfs, ideas or suggestions, please share. | |||
|
|||
You can use these quick links for Twitter and Linkedin. | |||
|
|||
[Twitter](https://twitter.com/intent/tweet?url=https://github.com/satwikkansal/wtfpython&hastags=python,wtfpython) | | |||
[Twitter](https://twitter.com/intent/tweet?url=https://github.com/satwikkansal/wtfpython&hastags=python,wtfpython) | | |||
[Linkedin](https://www.linkedin.com/shareArticle?url=https://github.com/satwikkansal&title=What%20the%20f*ck%20Python!&summary=An%20interesting%20collection%20of%20subtle%20and%20tricky%20Python%20snippets.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That spa with the separator was intentional
2551b7c
to
b6ee6da
Compare
Oops. This should be good now. I put |
And merged... |
Thank you so much @ariasuni 😄 |
No description provided.