Skip to content

Conversation

ariasuni
Copy link
Contributor

No description provided.

README.md Outdated
@@ -1400,7 +1400,7 @@ Okay, now it's deleted :confused:
+ `del x` doesn’t directly call `x.__del__()`.
+ Whenever `del x` is encountered, Python decrements the reference count for `x` by one, and `x.__del__()` when x’s reference count reaches zero.
+ In the second output snippet, `y.__del__()` was not called because the previous statement (`>>> y`) in the interactive interpreter created another reference to the same object, thus preventing the reference count to reach zero when `del y` was encountered.
+ Calling `globals` caused the existing reference to be destroyed and hence we can see "Deleted!" being printed (finally!).
+ Calling `globals` caused the existing reference to be destroyed and hence we can see Deleted! being printed (finally!).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of quotes replaced (" with “) in the PR. Is there any difference in the meanings of both the characters. The one you replace it with isn't a character typed by standard keyboard.

Copy link
Contributor Author

@ariasuni ariasuni Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have the same meaning. These are the modern, better looking, more readable, English opening and closing quotes. There are easily available – though not widely known – on modern keyboard layouts.

If you don’t like it though, I can discard that change from my PR.

(To be honest I was tempted to change from ... to but at first I thought it was too many little changes)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have the same meaning. These are the modern, better looking, more readable, English opening “ and closing ” quotes. There are easily available – though not widely known – on modern keyboard layouts.

Interesting, I didn't knew that :)

If you don’t like it though, I can discard that change from my PR.

The thing is, they are not ASCII. And given the fact anyone can contribute to the project, it'd be quite tedious to maintain consistency for quotes in the future examples. I hope you understand...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I totally understand. :)

@ariasuni ariasuni force-pushed the fix-spelling-and-typo branch from 2c5fe64 to 2551b7c Compare February 28, 2018 09:33
@ariasuni
Copy link
Contributor Author

I updated my branch :)

@@ -2127,7 +2127,7 @@ Why did `Yo()._Yo__honey` worked? Only Indian readers would understand.

---

## Section: Miscallaneous
## Section: Miscellaneous
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to update the TOC as well :)

README.md Outdated
@@ -2369,7 +2369,7 @@ If you have any wtfs, ideas or suggestions, please share.

You can use these quick links for Twitter and Linkedin.

[Twitter](https://twitter.com/intent/tweet?url=https://github.com/satwikkansal/wtfpython&hastags=python,wtfpython) |
[Twitter](https://twitter.com/intent/tweet?url=https://github.com/satwikkansal/wtfpython&hastags=python,wtfpython) |
[Linkedin](https://www.linkedin.com/shareArticle?url=https://github.com/satwikkansal&title=What%20the%20f*ck%20Python!&summary=An%20interesting%20collection%20of%20subtle%20and%20tricky%20Python%20snippets.)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That spa with the separator was intentional

@ariasuni ariasuni force-pushed the fix-spelling-and-typo branch from 2551b7c to b6ee6da Compare February 28, 2018 12:21
@ariasuni
Copy link
Contributor Author

Oops. This should be good now. I put | at the start of the next line so editing your document with editors that remove trailing lines will not break this again.

@satwikkansal satwikkansal merged commit db35390 into satwikkansal:master Feb 28, 2018
@satwikkansal
Copy link
Owner

And merged...

@satwikkansal
Copy link
Owner

Thank you so much @ariasuni 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants