Fixed input-output of 4th example explanation code #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deep down we're all the same: Input-Output formatting of the explanation code https://github.com/satwikkansal/wtfpython#-deep-down-were-all-the-same-
README.md
Outdated
| def __init__(self): print("I ") | ||
| def __del__(self): print("D ") | ||
| def __init__(self): print("I", end = " ") | ||
| def __del__(self): print("D", end = " ") |
There was a problem hiding this comment.
Hi, end = " " is python 3 specific. That's why I omitted it initially 😅
There was a problem hiding this comment.
It is the output which we should change IMO to avoid breaking this on Python 2.x
There was a problem hiding this comment.
If that's the case, then the output can be shown as
I
D
I
D
True
README.md
Outdated
| >>> id(WTF()) == id(WTF()) | ||
| I D I D | ||
| I D I D True |
There was a problem hiding this comment.
Thanks for pointing this out and fixing it :)
Ref. example: Deep down, we're all the same
|
Merged! Thank you so much @Vibhu-Agarwal for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep down we're all the same: Input-Output of the explanation code