Skip to content

Improvement BubbleSort algorithm #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improvement BubbleSort algorithm #6

wants to merge 2 commits into from

Conversation

bonejah
Copy link

@bonejah bonejah commented May 8, 2021

Hi @satya-verma, first of all thanks for sharing the code in the course ZTM-Data-Structure-Algorithms!

So, I'm learning algorithms and I realized that your BubbleSort algorithm could be improvement if you decrise the size in your first for loop!

This is a small fix that prevents to make one more loop unnecessary!

Follow some example:

After
PRINT ARRAY BEFORE: [100, 200, 10, 7, 5, 6, 3]
Value i ==> 0
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[100, 10, 7, 5, 6, 3, 200]
--------------------------------
Value i ==> 1
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[10, 7, 5, 6, 3, 100, 200]
--------------------------------
Value i ==> 2
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[7, 5, 6, 3, 10, 100, 200]
--------------------------------
Value i ==> 3
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[5, 6, 3, 7, 10, 100, 200]
--------------------------------
Value i ==> 4
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[5, 3, 6, 7, 10, 100, 200]
--------------------------------
Value i ==> 5
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[3, 5, 6, 7, 10, 100, 200]
--------------------------------
Value i ==> 6
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[3, 5, 6, 7, 10, 100, 200]
--------------------------------


Before
PRINT ARRAY BEFORE: [100, 200, 10, 7, 5, 6, 3]
Value i ==> 0
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[100, 10, 7, 5, 6, 3, 200]
--------------------------------
Value i ==> 1
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[10, 7, 5, 6, 3, 100, 200]
--------------------------------
Value i ==> 2
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[7, 5, 6, 3, 10, 100, 200]
--------------------------------
Value i ==> 3
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[5, 6, 3, 7, 10, 100, 200]
--------------------------------
Value i ==> 4
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[5, 3, 6, 7, 10, 100, 200]
--------------------------------
Value i ==> 5
Value j ==> 0
Value j ==> 1
Value j ==> 2
Value j ==> 3
Value j ==> 4
Value j ==> 5
[3, 5, 6, 7, 10, 100, 200]
--------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bonejah