Skip to content

fix: require bash script plugin when packaging #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

pvlugter
Copy link
Member

Fixes #28. Make sure bash script plugin default settings are applied first.

@pvlugter
Copy link
Member Author

A little trickier. This plugin still cross builds against sbt 0.13, and so it tests against much older versions of sbt-native-packager, which don't have BashStartScriptPlugin. And the sbt-native-packager 1.1.6 jar does contain a broken BashStartScriptPlugin class for some reason, even though it shouldn't be there based on the sources.

Could work around these, but wonder if it's time to move on from sbt 0.13 for this plugin? Older versions of the plugin can still be used.

@pvlugter
Copy link
Member Author

pvlugter commented Oct 25, 2023

As there's a broken BashStartScriptPlugin included in sbt-native-packager 1.1.6 for some reason, failing to load with:

java.lang.NoSuchMethodError: com.typesafe.sbt.packager.Keys$.bashScriptReplacements()Lsbt/TaskKey;

rather than making this plugin optional, have only included it for sbt 1.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pvlugter pvlugter merged commit e006319 into master Oct 25, 2023
@pvlugter pvlugter deleted the bash-start-script-plugin branch October 25, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is this broken in sbt 1.9.7?
2 participants