Skip over JEP 445 compact compilation units #11066
Conversation
test/files/pos/t12878/T.java
Outdated
| //> using javacOpt --enable-preview --release 21 | ||
|
|
||
| int k = 0; | ||
| // This should work as compact units have an implicit `import module java.base`, but that doesn't seem to be the case with Java 21 preview |
There was a problem hiding this comment.
could use 25 directly, as no one cares about regression on old preview
There was a problem hiding this comment.
I recognize you might wish to see it run and pass today, however.
There was a problem hiding this comment.
Right, though we run 25 already on CI. I'll do that.
| val ts = termDecl(mods, CLASS) | ||
| if (ts.nonEmpty) compact = true | ||
| Nil | ||
| } |
There was a problem hiding this comment.
I might have generalized typeDeclOrCompactTerm(mods)(orElse: Tree) which typeDecl would call.
I might have orElse throw here to long jump back to a try in compilationUnit.
That would be to avoid listing tokens at L1097. OTOH, the method is so small this is fine.
There is a return in that interactive code, so maybe I have early return on the brain.
|
TIL OED notes intransitive "reference" having to do with (I think) cataloguing properties which must be acquired by eminent domain for a railroad. That strikes me as a very British coinage, that is, putting that disruptive practice behind a neutral term that doesn't even take a direct object. In the U.S., it's just called capitalism. To make too fine a distinction, does "reference" imply authoritative reference? Then one could reference a stable reference (in our terminology). Or perhaps conversely, every reference in computing is authoritative to mean correct and not erroneous, and therefore can be referenced. From C pointer days, we would say "dereference" for this action of actually finding the referent. That is at runtime. That might imply that at compiletime, one does not reference simply any identifier, but only identifiers with the strongest guarantees (that they are not null, perhaps). The weak sense is that referrible means in the namespace and accessible. |
Compact compilation units are not referencable, so we can skip over them.
Compact compilation units are not referenceable, so we can skip over them.
Fixes scala/bug#12878