Name implicit removal #1693
Name implicit removal #1693
Conversation
And simplify the name implicits.
These implicits were crutches going back to a much Stringier time. Of course "with great type safety comes great verbosity" and no doubt this could be cleaned up significantly further. At least the underpinnings are consistent now - the only implicits involving name should be String -> TypeName and String -> TermName.
| @@ -143,7 +143,7 @@ trait GenSymbols { | |||
| val reification = reificode(sym) | |||
| import reification.{name, binding} | |||
| val tree = reification.tree updateAttachment ReifyBindingAttachment(binding) | |||
| state.symtab += (sym, name, tree) | |||
| state.symtab += (sym, name.toTermName, tree) | |||
There was a problem hiding this comment.
Probably name in the Reification case class should be made TermName instead of just Name. Then the necessity of this change will vanish.
There was a problem hiding this comment.
There's a lot of that sort of thing; I went with "eliminate the implicits" as first pass. Followup commits encouraged.
There was a problem hiding this comment.
Allright, will do after this PR is merged.
|
lgtm |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1758/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1758/ |
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1071/ |
|
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1071/ |
Review by @xeno-by