[backport] SI-6969, mishandling of SoftReferences in method cache. #1972
Conversation
More interesting to test than it was to fix. The soft reference is now dereferenced once, the locally stored underlying value ascertained to be non-null, and the remainder of the references to the value use the local var. The enclosed test reliably NPEs without this patch.
|
@paulp I backported it as mentioned in https://issues.scala-lang.org/browse/SI-6969 I guess now the people in charge need to decide whether it is important enough. :-) Backport of #1902 |
|
PLS REBUILD ALL |
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1632/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/2363/ |
|
jenkins job pr-rangepos: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1632/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/2363/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/2363/ |
|
PLS REBUILD ALL |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/2377/ |
|
jenkins job pr-rangepos: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1632/ |
|
Thanks for doing the backport! Unfortunately, the milestone was somehow set to 2.10.1-RC1, so I didn't see this when I cut 2.9.3-RC2. Apologies. |
|
@adriaanm turns out the failure was genuine so it wouldn't have made it anyway. |
|
Never mind, it's a test problem in 2.9.x and can be ignored. |
|
LGTM. I'll merge it for the next 2.9.x release. |
[backport] SI-6969, mishandling of SoftReferences in method cache.
[backport] SI-6969, mishandling of SoftReferences in method cache.
More interesting to test than it was to fix. The soft
reference is now dereferenced once, the locally stored
underlying value ascertained to be non-null, and the
remainder of the references to the value use the local var.
The enclosed test reliably NPEs without this patch.