SI-7109 SI-7153 Generalize the API to get docComments: allow to force do... #2156
Conversation
|
Review by @huitseeker. |
… docTrees for given fragments. Don't type-check when forcing doc comments, but rather do it directly. Test the new functionality as well as better tests for the old one.
|
ping @huitseeker |
|
Review by @dragos |
|
I'm very sorry for the time it took me to get back to this review. This is a great PR, which deserved swifter treatment (I'm marred by build problems I'm only solving now — again, I'm sorry). An unrelated test fails reliably (@dragos reproduced the problem : LGTM ! |
|
If you rebase against the head of 2.10.x, the test failure will be fixed. |
|
@JamesIry ping. Should I rebase? |
|
Let's find out... |
|
PLS REBUILD ALL |
|
(kitty-note-to-self: ignore 14447871) |
|
it builds ok: https://scala-webapps.epfl.ch/jenkins/job/pr-checkin-per-commit/856/console merging so @paulp 's refactoring isn't blocked |
SI-7109 SI-7153 Generalize the API to get docComments: allow to force do...
|
@adriaanm but of course I really need it to make it all the way to master. I can merge 2.10.x into master if necessary, unless someone is already? |
|
I just submitted a PR. On Tue, Mar 5, 2013 at 11:18 AM, Paul Phillips notifications@github.comwrote:
|
...cTrees
for given fragments. Don't type-check when forcing doc comments, but rather
do it directly. Test the new functionality as well as better tests for
the old one.