[backport] SI-7391 Always use ForkJoin in Scala actors #2413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
review by @phaller |
| @@ -37,17 +37,5 @@ private[actors] object ThreadPoolConfig { | |||
| if (preMaxSize >= corePoolSize) preMaxSize else corePoolSize | |||
| } | |||
|
|
|||
| private[actors] def useForkJoin: Boolean = | |||
| try !propIsSetTo("actors.enableForkJoin", "false") && | |||
| (propIsSetTo("actors.enableForkJoin", "true") || { | |||
There was a problem hiding this comment.
We should still honor the actors.enableForkJoin system property. It should be possible to explicitly not use the ForkJoinPool by setting actors.enableForkJoin to false. Especially, since this PR targets 2.9.x. So, why not simply drop all the vendor checks in the Boolean expression below?
... on Java 6 and above, but keep honoring the actors.enableForkJoin system property. Like SI-7236 and SI-7237, the logic in scala.actors.scheduler.ThreadPoolConfig.useForkJoin (which resulted in a different thread pool implementation being chosen) was causing random hangs in the test concurrent-stream.scala when running on Avian.
|
@phaller Updated! |
|
LGTM |
adriaanm
added a commit
that referenced
this pull request
May 3, 2013
[backport] SI-7391 Always use ForkJoin in Scala actors
bishabosha
pushed a commit
to scalacenter/scala
that referenced
this pull request
Jun 26, 2020
[backport] SI-7391 Always use ForkJoin in Scala actors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... on Java 6 and above.
Like SI-7236 and SI-7237, the logic in
scala.actors.scheduler.ThreadPoolConfig.useForkJoin
(which resulted in a different thread pool implementation
being chosen) was causing random hangs in the test
concurrent-stream.scala when running on Avian.