[backport] no longer warns on calls to vampire macros #3602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As eloquently elaborated and cleverly named by Travis Brown, macros defined in structural types are useful: http://meta.plasm.us/posts/2013/07/12/vampire-methods-for-structural-types/. However, since such macros are on the intersection of a number of language features, as usual, there are bugs. This commit fixes an unwanted interaction of macros defined in structural types with the scala.language.reflectiveCalls guard. Since macro calls aren't going to be carried to runtime, there's no need to warn about them.
|
review @retronym |
|
I first read "An eloquently elaborated and cleverly named Travis Brown [...]" ... looks good to me otherwise. :-) |
|
Ping @retronym |
retronym
added a commit
that referenced
this pull request
Mar 22, 2014
[backport] no longer warns on calls to vampire macros
|
LGTM |
retronym
added a commit
to retronym/scala
that referenced
this pull request
Mar 22, 2014
Merged with `-s ours`, all commits in cbb88ac...daa77d1 where backports to 2.10.x or changes to the 2.10.x build. git log --graph --oneline --decorate $MB...origin/2.10.x * daa77d1 (origin/pr/3648, origin/2.10.x) Merge pull request scala#3602 from xeno-by/topic/backport-vampire-warni |\ | * db300d4 (xenoby/topic/backport-vampire-warning, origin/pr/3602) [backport] no longer warns on calls to vam * | 43e06be Merge pull request scala#3643 from gkossakowski/2.10.5-nightlies |\ \ | |/ |/| | * a16e003 (origin/pr/3643) Bump version to 2.10.5 for nightly builds. |/ * b66a396 (tag: v2.10.4-RC3, tag: v2.10.4, xenoby/2.10.x, huit/2.10.x) Merge pull request scala#3491 from retrony |\ | * 5f4011e (retronym/backport/7902, origin/pr/3491) [backport] SI-7902 Fix spurious kind error due to an unit |/ * 5720e97 Merge pull request scala#3430 from som-snytt/issue/8205-backport |\ | * 8ee165c (origin/pr/3430) SI-8205 [nomaster] backport test pos.lineContent * 50453ce Merge pull request scala#3415 from xeno-by/topic/reify210x |\ | * d167f14 (origin/pr/3415) [nomaster] corrects an error in reify’s documentation |/ * 6557570 Merge pull request scala#3359 from huitseeker/issue/VarianceAdaptations |\ | * 806b6e4 (origin/pr/3359, huit/issue/VarianceAdaptations) Backports library changes related to SI-6566 from * d9ee69f Merge pull request scala#3367 from retronym/backport/3363 * ff13742 (retronym/backport/3363, origin/pr/3367) [nomaster] SI-8146 Fix non-deterministic <:< for deeply nes * cbb88ac [nomaster] Update MiMa and use new wildcard filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As eloquently elaborated and cleverly named by Travis Brown, macros
defined in structural types are useful:
http://meta.plasm.us/posts/2013/07/12/vampire-methods-for-structural-types/.
However, since such macros are on the intersection of a number of language
features, as usual, there are bugs.
This commit fixes an unwanted interaction of macros defined in structural
types with the scala.language.reflectiveCalls guard. Since macro calls
aren't going to be carried to runtime, there's no need to warn about them.