Skip to content

Reword javap filtering options #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2014
Merged

Reword javap filtering options #3680

merged 1 commit into from
Apr 24, 2014

Conversation

dcsobral
Copy link
Contributor

"To filter out" means remove, and, therefore, has the exact opposite meaning of what the example shows. But "filter" is kind of an ambiguous word when it comes to what's removed and what's left, not to mention which you are interested in (if you filter water to drink that's one thing, if you filter water to mine gold, that's another), so I'm avoiding it altogether and going for some unambiguous.

"To filter out" means remove, and, therefore, has the exact opposite meaning of what the example shows. But "filter" is kind of an ambiguous word when it comes to what's removed and what's left, not to mention which you are interested in (if you filter water to drink that's one thing, if you filter water to mine gold, that's another), so I'm avoiding it altogether and going for some unambiguous.
@som-snytt
Copy link
Contributor

Thanks. I didn't write that text, but I did have a period in which I would wake up in a cold sweat from a nightmare in which I could never remember if it meant filter in or filter out. I blame Brita. When I realized that "cull" is ambiguous in the same way, I stopped worrying.

If it's any solace, I noticed that the feature broke at some point. I especially notice it when I go looking for an anonfun. How I hate anonfuns now. They used to be fun.

@som-snytt
Copy link
Contributor

The other text change (unrelated to this PR) is that retronym enabled :se -Xlint:true which is nicer than :se +Xlint (which still works). Probably the feature should just take :se -Xlint as true. In other CLI, like -XX:+TraceClassLoading or whatever, I can never remember how it goes.

@adriaanm
Copy link
Contributor

Thanks. How do you feel about moving the gh-pages branch to https://github.com/scala/scala.github.com?

adriaanm added a commit that referenced this pull request Apr 24, 2014
Reword javap filtering options
@adriaanm adriaanm merged commit f1b8fee into scala:gh-pages Apr 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants