Looks like a flakey test in the scala-refactoring suite.

Results :

Failed tests: 
  ReusingPrinterTest.add_override_final_flags_to_lazy_val:138 expected:<...T extends T {
      [override final ]lazy val meth = 0
  ...> but was:<...T extends T {
      []lazy val meth = 0
  ...>

PLS REBUILD ALL

This change fulfils part I of https://issues.scala-lang.org/browse/SI-4223.

(kitty-note-to-self: ignore 56330649)
🐱 Roger! Rebuilding pr-scala for 9902ae5. 🚨

It is probably worthwhile to discuss what we would need to do to turn this on by default in the REPL.

To avoid the effecting tools that programatically drive the REPL, we could predicate it based on a suitable terminal environment:

scala> new jline.console.ConsoleReader().getTerminal.isAnsiSupported
res3: Boolean = true

We could also have a system property to turn it off explicitly.

Maybe we'd target this change at 2.12 both to be conservative and to give the feature (and the colour pallette) some time to mature.

I think you might have missed a spot.

@retronym I did, thank you.

Cool, more flair for the REPL! What's the status of the missed spot?

Given missing activity, rescheduling for 2.11.4 (to happen at the end of November).

I'm happy to work on this tonight, if that's not too late to get into this release.

Hi @puffnfresh!
We are blocked by https://issues.scala-lang.org/browse/SI-8890 for which fix should arrive tomorrow. Let's give this PR another try, then. However, if you or us will feel tomorrow that this didn't have enough of time to fully bake, we'll reschedule it for 2.11.4, ok?

@gkossakowski sounds great 👍

@gkossakowski good to go:

How does it look on a light black-on-white themed terminal?

@retronym as far as I know, most terminals choose colours which work on black or white. You be the judge, though:

That looks good enough for now. If we turn it on by default in 2.12, we can polish that a little further. Thanks!

Yeah, I'm hoping for a tiny amount of data before the bike shedding starts.

Yay, nice idea. 👍

FTR: here's how to enable it automatically in sbt:

Put this into your ~/.sbt/0.13/user.sbt:

initialize ~= { _ =>
  val ansi = System.getProperty("sbt.log.noformat", "false") != "true"
  if (ansi) System.setProperty("scala.color", "true")
}

@jrudolph 👍

I would suggest to predicate this on sbt.ConsoleLogger.formatEnabled, which incorporates the checks for the system property sbt.nologformat and the capabilities of the terminal.

% sbt "eval sbt.ConsoleLogger.formatEnabled"
[info] Loading global plugins from /Users/jason/.sbt/0.13/plugins
[info] Set current project to scala (in build file:/Users/jason/code/scala/)
[info] ans: Boolean = true

% sbt -Dsbt.log.noformat=true "eval sbt.ConsoleLogger.formatEnabled"
[info] Loading global plugins from /Users/jason/.sbt/0.13/plugins
[info] Set current project to scala (in build file:/Users/jason/code/scala/)
[info] ans: Boolean = false

Was this announced anywhere? This is probably the biggest improvement to the Scala REPL since the great war of 1939

;-) i believe it was included in forSome release notes, but happy to tout it again (handwritten.md over at scala/make-release-notes)

Wherever you put it, Google can't find it, because I've googled this and clicked-through the JIRA ticket at least 5 times by this point =P

thank u~