Avoid inefficient specialized lambdas w. delambdafy jvm-1.8, GenASM #4508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change disabled -Ydelambdafy:method for specialized lambdas, as `DelambdafyTransformer` made no attempt to emit the requisite machinery to avoid boxing. This was loosened to allow them under `-target:jvm-1.8`, in the knowledge that `indylambda` would do the right thing. However, this wasn't quite right: indylambda is only supported in `GenBCode`, so we should consider that setting as well.
|
Review by @lrytz |
|
LGTM |
|
/synch |
lrytz
added a commit
that referenced
this pull request
May 20, 2015
Avoid inefficient specialied lambdas w. delambdafy jvm-1.8, GenASM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change disabled -Ydelambdafy:method for specialized
lambdas, as
DelambdafyTransformermade no attempt to emitthe requisite machinery to avoid boxing.
This was loosened to allow them under
-target:jvm-1.8, in theknowledge that
indylambdawould do the right thing.However, this wasn't quite right: indylambda is only supported
in
GenBCode, so we should consider that setting as well.