SIP-14 fixes #455
Closed
SIP-14 fixes #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure completeWith doesn't crash on multiple attempts.
…reat racing completeWiths as a problem or not.
… out newPromise to the implementations instead of having it inside impl.Promise
… for boxing of callback and for execution
|
This conflicts with pull 454, and I can't be trusted to iron out the difference. Since it came in first I'm merging that one; so assuming the tests pass this one needs a nudge. |
szeiger
pushed a commit
to szeiger/scala
that referenced
this pull request
Mar 20, 2018
* Fix typo. * Bump sbt version. * Cache for Travis CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean ups and fixes from @viktorklang 's pull request #15 against
phaller/scala. Review by @phaller.