SI-9348 Fix missing last element in exclusive floating point ranges #4562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix exclusive floating point ranges to contain also the last element when the end-start difference is not an integer multiple of step.
|
LGTM |
|
There's no need to create a separate PR for 2.12, we regularly merge 2.11 into 2.12. Sorry for your effort, we should have a prominent note about this in the contributor's guide.. |
|
Ok, no problem. Effort is a bit over-statement for copy-pasting :D |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix exclusive floating point ranges to contain also the last element
when the end-start difference is not an integer multiple of step.
Review by @axel22
(Note: the hash is different here since I removed one unused import that got in. Otherwise identical cherry-pick.)