Default to delambdafy:method and backend:GenBCode #4580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failures expected, will require a rebase once #4578 gets merged. |
Merged
| @@ -224,7 +224,7 @@ trait ScalaSettings extends AbsScalaSettings | |||
|
|
|||
| val exposeEmptyPackage = BooleanSetting("-Yexpose-empty-package", "Internal only: expose the empty package.").internalOnly() | |||
| // the current standard is "inline" but we are moving towards "method" | |||
There was a problem hiding this comment.
Comment is out of date now, I'd just remove it.
looking into those today |
|
@retronym there's a number of tests that need to be rewritten, for example those using |
|
That's fine with me. Let's remind ourselves with a blocker ticket for m3 |
|
@retronym fixed the tests. The commit here is a squashed version of this: https://github.com/scala/scala/compare/2.12.x...lrytz:defaultsWip?expand=1 |
Switch the defaults of `-Ydelambdafy` and `-Ybackend`. Rewrite t6288b-jump-position test - no more icode Don't crash GenBCode beyond JVM code size limits A similar patch is in GenASM, see 3fa2c97 Fix check files for GenBCode / delambdafy:method defaults Force copy propagation test to ASM, see SI-9364 Force inline-ex-handlers test to GenASM, see SI-9364 Move t6613 test to pending - still broken in GenBCode Adding a `flags` file with `-Ybackend:GenASM` doesn't seem to have the desired effect. SI-6613 is re-opened. Force a few tests to GenASM, see SI-9364
It was fixed in GenASM in 44807a7.
|
LGTM |
lrytz
added a commit
that referenced
this pull request
Jun 26, 2015
Default to delambdafy:method and backend:GenBCode
This was referenced Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swtich the defaults of
-Ydelambdafyand-Ybackend.