Fixing signatures of universal methods on Any and AnyRef.
#4772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods `getClass`, `isInstanceOf`, `asInstanceOf`, `notify`, `notifyAll`, and `wait` should be final. Method `getClass` should exist only on Any.
|
LGTM |
lrytz
added a commit
that referenced
this pull request
Oct 5, 2015
Fixing signatures of universal methods on `Any` and `AnyRef`.
|
thanks, Vojin, for catching this, and for submitting a fix. |
|
It was on my was as I was defining virtualization for Scala. Thanks for merging quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods
getClass,isInstanceOf,asInstanceOf,notify,notifyAll, andwaitshould be final.Method
getClassshould exist only on Any.I am considering this a documentation change as this file is not linked. Review by @heathermiller