Improvement to resetAttrs and reification #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to locally erased symbols.
Improvements to reification and resetAttrs
|
In my branch (https://github.com/scalamacros/kepler/commits/topic/reify) I've added some logically related stuff. Maybe we can review all these things tomorrow, pack them into a single commit and submit a different pull request? Also, commit 8fba3be in this pull request is the same as commit e391900 in #71. Sorry for not being vocal enough about where I put those changes. |
|
Also, upgrades to resetAllAttrs still don't work for List[C]: https://github.com/scalamacros/kepler/blob/ec4fa214cb1c25536a81081d8d39a4dd0e25d0cc/test/files/run/reify_generic2.scala |
|
Well resubmit another pull request. This one can be abandoned,. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes to resetAttrs and reification which are useful independently of further progress.