Skip to content

Fix "cannot be represented as URI" in JDK 13 #8210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2019
Merged

Fix "cannot be represented as URI" in JDK 13 #8210

merged 1 commit into from
Jul 11, 2019

Conversation

retronym
Copy link
Member

@retronym retronym commented Jul 10, 2019 •
edited by lrytz
Loading

This change in the JDK:

openjdk/jdk@ac6c642#diff-e9881878ce74700a8063f67f65ec0657

Led us to the "cannot be represented as URI" exception.

This commit just hard-codes jrt:/ as the URI

fixes scala/bug#11608

@retronym
Fix scalac compatibility with JDK 13
0aec263 
This change in the JDK:

openjdk/jdk@ac6c642#diff-e9881878ce74700a8063f67f65ec0657

Led us to the "cannot be represented as URI" exception.

This commit just hard-codes jrt:/ as the URI
@scala-jenkins scala-jenkins added this to the 2.12.9 milestone Jul 10, 2019
@retronym retronym requested a review from lrytz July 10, 2019 08:42
@retronym retronym mentioned this pull request Jul 10, 2019
Closed
1 task
@diesalbla diesalbla added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Jul 10, 2019
@lrytz lrytz merged commit bd6d220 into scala:2.12.x Jul 11, 2019
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Jul 15, 2019
@SethTisue SethTisue mentioned this pull request Jul 15, 2019
Closed
@eed3si9n eed3si9n changed the title Fix scalac compatibility with JDK 13 Fix "cannot be represented as URI" in JDK 13 Aug 1, 2019
@eed3si9n eed3si9n mentioned this pull request Aug 11, 2019
Closed
@lukaseder lukaseder mentioned this pull request Aug 12, 2019
Closed
@lukaseder
Copy link

Thanks for integrating this so quickly, folks!

@izhangzhihao izhangzhihao mentioned this pull request Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

Assignees
No one assigned
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups) release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.12.9
Development

Successfully merging this pull request may close these issues.
6 participants
@retronym @lukaseder @lrytz @SethTisue @scala-jenkins @diesalbla