Skip to content

Issue SI-4824. Fixes stack overflow bug when parsing long multiline comments #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2014
Merged

Conversation

nimishgupta
Copy link
Contributor

No description provided.

@gourlaysama
Copy link
Contributor

@nimishgupta thank you for fixing this. Could you prefix your commit message with the issue number (SI-4824), and change strack overflow -> stack overflow?

Sorry it took so long to get to this...

…stack overflow bug when parsing long multiline comments
@nimishgupta nimishgupta changed the title Fixes strack overflow bug when parsing long multiline comments Issue SI-4824. Fixes stack overflow bug when parsing long multiline comments Jul 7, 2014
@nimishgupta
Copy link
Contributor Author

@gourlaysama Thank you for taking a look. I have made the requested changes.

@gourlaysama
Copy link
Contributor

LGTM. Thanks a lot!

gourlaysama added a commit that referenced this pull request Jul 9, 2014
SI-4824 Fix stack overflow bug when parsing long multiline comments
@gourlaysama gourlaysama merged commit 27d7770 into scala:master Jul 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants