Skip to content

Scala.js artifacts don’t declare a versionScheme #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julienrf opened this issue Jun 17, 2021 · 2 comments · Fixed by #4517
Closed

Scala.js artifacts don’t declare a versionScheme #4513

julienrf opened this issue Jun 17, 2021 · 2 comments · Fixed by #4517
Assignees
@sjrd
Labels
enhancement Feature request (that does not concern language semantics, see "language")
Milestone
v1.7.0

Comments

@julienrf
Copy link
Contributor

The Scala.js artifacts don’t declare a versionScheme, therefore I am not sure which conclusions can be drawn from dependency resolution tools.

See e.g. scala/scala-xml#533
@sjrd
Copy link
Member

sjrd commented Jun 17, 2021 •
edited
Loading

How can we do this while still using sbt 1.2.8 ourselves?

@julienrf
Copy link
Contributor Author

The simplest solution regarding the declaration of the versioning scheme would be to upgrade to sbt 1.5. If this is not possible, I guess you would have to add something like:

Compile / packageBin / artifact ~= _.extra("info.versionScheme" -> "early-semver")

(untested)

sjrd added a commit to sjrd/scala-js that referenced this issue Jun 22, 2021
@sjrd
Fix scala-js#4513: Set up versionScheme for all the published artif…
9ba5db5 
…acts.
@sjrd sjrd self-assigned this Jun 22, 2021
@sjrd sjrd added this to the v1.6.1 milestone Jun 22, 2021
@sjrd sjrd added the enhancement Feature request (that does not concern language semantics, see "language") label Jun 22, 2021
sjrd added a commit to sjrd/scala-js that referenced this issue Jun 23, 2021
@sjrd
Fix scala-js#4513: Set up versionScheme for all the published artif…
8574be9 
…acts.
sjrd added a commit to sjrd/scala-js that referenced this issue Jun 28, 2021
@sjrd
Fix scala-js#4513: Set up versionScheme for all the published artif…
0fada39 
…acts.
@sjrd sjrd linked a pull request Jul 13, 2021 that will close this issue
Fix #4513: Set up versionScheme for all the "library" artifacts. #4517
Merged
sjrd added a commit to sjrd/scala-js that referenced this issue Jul 30, 2021
@sjrd
Fix scala-js#4513: Set up versionScheme for all the published artif…
0b98a74 
…acts.
sjrd added a commit to sjrd/scala-js that referenced this issue Jul 30, 2021
@sjrd
Fix scala-js#4513: Set up versionScheme for all the "library" artif…
8c60492 
…acts.

We do not set the version scheme for "tools" artifacts yet, as the
jury is still out on what is the best way to specify them.
sjrd added a commit that referenced this issue Jul 30, 2021
@sjrd
Merge pull request #4517 from sjrd/version-scheme
46be6ba 
Fix #4513: Set up versionScheme for all the "library" artifacts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjrd sjrd

Labels
enhancement Feature request (that does not concern language semantics, see "language")
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging a pull request may close this issue.

Fix #4513: Set up versionScheme for all the "library" artifacts. sjrd/scala-js
2 participants
@julienrf @sjrd