Can one of the admins verify this patch?

test this please

@l15k4 Could you confirm that you didn't look at OpenJDK's code for this?

@sjrd I looked at Oracle's JDK :-)

Ach. Well, that's as much a problem. We can't accept code that's been derived from any JDK because their licenses are not compatible with ours (excluding Apache Harmony). :-(

What I meant was that I adhered to the "protocol/spec" these methods have :

1. param values restrictions
2. behavior (exclusive end,inclusive start)

Not that I have copied the code... We work with String, they work with Char Arrays

OK, I suppose that's fine.

I'll repeat here my comment from #1106:
Could you please sign the CLA (see #1139). I also see that your commits are under the name @viagraphs. You should configure your GitHub account so it knows that the appropriate e-mail address is attached to your account. Otherwise we can't track the CLA status.
Thanks.

That's all.

Done and Done :-)

Done and Done :-)

Thanks!

LGTM

test this please

Test PASSed.
Refer to this link for build results: https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/802/

Btw I have a suggestion regarding Character API, there is isLetter method not implemented because in JDK it depends on heavy java.lang.CharacterData class that it doesn't make sense to rewrite... But I think it might be done like :

val isLetterPattern = Pattern.compile("\\p{L}")
def isLetter(c: scala.Char): scala.Boolean = isLetterPattern.matcher(String.valueOf(c)).matches()

This method is heavily used, for instance parser combinators lib is pretty much broken without this method implemented... So I think that it is better to have something than nothing :-) Wdyt ? Should I make another PR or should I work it around at the third party libs ?

Our regexes do not support \p because they rely on JS regexes. So it's not that easy, unfortunately. See also #964 and #1201.

Test PASSed.
Refer to this link for build results: https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/803/

Just a quick question regarding living on the scalajs cutting edge, is there a way to publishLocal all projects, not just the aggregated ones? Like compiler, sbtPlugin, tools etc. I just always have to manually publishLocal each one and since I'm doing that not that regularly I always forget which need to be published

Can one of the admins verify this patch?

There's no direct way because some projects need to be published against your version of Scala (the aggregates) and some always with 2.10.4 (tools and sbtPlugin).

So it's:

> ++2.11.2
> publishLocal
> ++2.10.4
> tools/publishLocal
> sbtPlugin/publishLocal