Fix #3901: Do not fill groupStartMap for non-matching groups.
#3907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
approved these changes
Dec 18, 2019
`groupStartMap` is initially filled with `-1` everywhere, which is the correct value for non-matching groups. When propagating the `start` and `end` of a `GroupNode`, we previously always overrode that value with `start`, which can `>= 0` even for non-matching groups if they are within a negative look-ahead. This is incorrect, as non-matching groups must always report `-1` as their `start`. We now explicitly avoid overriding the initial `-1` for non-matching groups. This more closely corresponds to what was done in `GroupStartMap.setEndReturnStart` and `setStartReturnEnd` before the big rewrite of 56dd7ab.
272fb91 to
602005d
Compare
gzm0
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupStartMapis initially filled with-1everywhere, which is the correct value for non-matching groups. When propagating thestartandendof aGroupNode, we previously always overrode that value withstart, which can>= 0even for non-matching groups if they are within a negative look-ahead. This is incorrect, as non-matching groups must always report-1as theirstart.We now explicitly avoid overriding the initial
-1for non-matching groups. This more closely corresponds to what was done inGroupStartMap.setEndReturnStartandsetStartReturnEndbefore the big rewrite of 56dd7ab.