[no-master] Disable testing the test suite with PhantomJS on the CI. #3910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhantomJS is still by far the biggest cause of spurious failures of the CI. Since I have not seen any genuine bug uncovered by testing on PhantomJS (only) in the last few *years*, the cost of this test overwhelmingly exceeds its potential benefits. Therefore, in this commit we simply disable the last command that was running the test suite with PhantomJS, as well as the last command that was running non-optimized code with PhantomJS. PhantomJS is still minimally tested by its unit tests, as well as in the helloworld and the testingExample (in standard fastOpt and fullOpt modes).
gzm0
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhantomJS is still by far the biggest cause of spurious failures of the CI. Since I have not seen any genuine bug uncovered by testing on PhantomJS (only) in the last few years, the cost of this test overwhelmingly exceeds its potential benefits.
Therefore, in this commit we simply disable the last command that was running the test suite with PhantomJS, as well as the last command that was running non-optimized code with PhantomJS.
PhantomJS is still minimally tested by its unit tests, as well as in the helloworld and the testingExample (in standard fastOpt and fullOpt modes).