Skip to content

#3921: Workaround for MethodAccessorImpl NoClassDefError #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

xerial
Copy link
Contributor

@xerial xerial commented Jan 16, 2020

No description provided.

@@ -75,6 +75,7 @@ object LinkerImpl {
private val parentPrefixes = List(
"java.",
"scala.",
"sun.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a comment explaining why we have this, with a reference to the issue and possibly also the OpenJDK issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I'll add

@sjrd
Copy link
Member

sjrd commented Jan 16, 2020

Also this PR must target the release-1.0.0 branch. The master branch is now for 1.0.1 and later.

@sjrd sjrd requested a review from gzm0 January 16, 2020 22:45
@xerial xerial changed the base branch from master to release-v1.0.0 January 16, 2020 22:53
@xerial xerial changed the base branch from release-v1.0.0 to master January 16, 2020 22:53
@xerial
Copy link
Contributor Author

xerial commented Jan 16, 2020

ok. I'll retarget the branch. May need to create another PR.

@xerial
Copy link
Contributor Author

xerial commented Jan 16, 2020

Created another PR #3928 to target release-1.0.0 branch.

@xerial xerial closed this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants