Upgrade sbt to 1.3.13. #4360
Closed
Upgrade sbt to 1.3.13. #4360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the latest (and very likely last) 1.3.x version. Recent versions of Metals cannot import builds using sbt 1.2.x anymore. The initial import fails with a LinkageError because it wants to access a setting that was added in sbt 1.3.0. This change may make our sbt plugin incompatible with sbt 1.2.x builds, as our main source of tests for it are our own build. However, almost all the scripted tests force to use sbt 1.2.8, and should give some confidence that we aren't breaking anything. If we do, oh well, sbt 1.2.x is a bit old anyway.
gzm0
requested changes
Jan 6, 2021
| @@ -638,6 +638,9 @@ object Build { | |||
| } | |||
|
|
|||
| val thisBuildSettings = Def.settings( | |||
| // Disable sbt 1.3.x+'s supershell, because it's terribly annoying | |||
| useSuperShell := false, | |||
There was a problem hiding this comment.
Isn't this something that should go in the personal/local sbt config?
|
Turning into draft because it seems that things are recompiled every time with that version. |
|
Asking on sbt's gitter: https://gitter.im/sbt/sbt?at=5ff6e122787d8f79c8e86eba |
|
Superseded by #4516. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest (and very likely last) 1.3.x version.
Recent versions of Metals cannot import builds using sbt 1.2.x anymore. The initial import fails with a LinkageError because it wants to access a setting that was added in sbt 1.3.0.
This change may make our sbt plugin incompatible with sbt 1.2.x builds, as our main source of tests for it are our own build. However, almost all the scripted tests force to use sbt 1.2.8, and should give some confidence that we aren't breaking anything.
If we do, oh well, sbt 1.2.x is a bit old anyway.