Rely on sbt's run cancellation rather than building our own #4528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we know exactly what version of sbt introduced the correct Ctrl+C interruption? We should indicate it in the release notes. |
5d867a3 to
bcc1e4e
Compare
|
Seems like this is the commit that introduced this: I will experimentally verify this. |
|
Hmmm... It also seems to work with sbt 1.3.13. |
|
It does not work with sbt 1.2.0. Bisecting :) |
|
works with sbt 1.3.0. |
|
Does not work with sbt 1.2.8. So 1.3.0 is the first one where it works. |
sjrd
approved these changes
Jul 11, 2021
bcc1e4e to
66297e7
Compare
Since the upgrade to sbt 1.5.4, Ctrl+C during a run cancels it as expected. Therefore, we remove our custom implementation of a similar thing (which was buggy anyways, e.g. scala-js#4336). I believe it reasonable to expect users that need this feature to upgrade sbt.
66297e7 to
23186b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the upgrade to sbt 1.5.4, Ctrl+C during a run cancels it as
expected. Therefore, we remove our custom implementation of a similar
thing (which was buggy anyways, e.g. #4336).
I believe it reasonable to expect users that need this feature to
upgrade sbt.