Fix #3918: Record names of mutated fields instead of symbols. #4535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The analysis in the issue shows that scalac generates different symbols for the same field in rare situations: one in the class info decls, and another one in the trees. This was a problem for our `unexpectedMutatedField` handling. We work around this issue by storing the *names* of the mutated fields, instead of their symbols. By only doing that for fields in the current class, we ensure that it remains non ambiguous. In addition, we store the names of all mutated fields, not only the ones that were not "suspected" to be mutable; in 2.13, the symbol in the trees is correctly marked as mutable but not the one in the class decls.
gzm0
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analysis in the issue shows that scalac generates different symbols for the same field in rare situations: one in the class info decls, and another one in the trees. This was a problem for our
unexpectedMutatedFieldhandling.We work around this issue by storing the names of the mutated fields, instead of their symbols. By only doing that for fields in the current class, we ensure that it remains non ambiguous. In addition, we store the names of all mutated fields, not only the ones that were not "suspected" to be mutable; in 2.13, the symbol in the trees is correctly marked as mutable but not the one in the class decls.