Introduce UnaryOp.CheckNotNull in the IR.
#5037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d38ebf5 to
2fff817
Compare
gzm0
approved these changes
Sep 17, 2024
|
|
||
| @deprecated("use the overload with the argument type instead", since = "1.17.0") | ||
| def resultTypeOf(op: Code): Type = | ||
| resultTypeOf(op, NothingType): Type |
There was a problem hiding this comment.
I'd remove this. It doesn't yield a correct result for CheckNotNull.
| @@ -2056,7 +2056,7 @@ object Build { | |||
| Some(ExpectedSizes( | |||
| fastLink = 425000 to 426000, | |||
| fullLink = 282000 to 283000, | |||
| fastLinkGz = 61000 to 62000, | |||
| fastLinkGz = 60000 to 61000, | |||
There was a problem hiding this comment.
Heh, nice. Do you know what that is?
There was a problem hiding this comment.
I'm not exactly sure. Apparently the inlining of vals can be a little bit better in some cases. This is the diff: https://gist.github.com/sjrd/28e5929fa16e0e030a3384bfad1fe59b
Now that we have non-nullable reference types in the IR, it makes sense to offer that operation at the IR level. It replaces the `Transient` of the same name. We use it in the compiler instead of `GetClass`, as it is more direct.
2fff817 to
a707dea
Compare
gzm0
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have non-nullable reference types in the IR, it makes sense to offer that operation at the IR level. It replaces the
Transientof the same name.We use it in the compiler instead of
GetClass, as it is more direct.