Fix #5115: Apply the StoreModule hack to JSConstructorDef from 1.8. #5116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m 1.8. Before 1.11, the body of `JSConstructorDef`s was a straight list of trees. We have a hack that extracts the three parts of a structured `JSConstructorBody`: `beforeSuper`, `superCall` and `afterSuper`. In 1.18, we introduced a separate hack to ensure that `afterSuper` starts with a `StoreModule` instruction. Unfortunately, we did not apply the latter hack on the result of the former. This means our deserializer incorrectly reads JS module classes from before 1.11. This commit makes sure to also apply the hack in that situation. Unfortunately, this does not come with automated tests. We do not have any non-native JS module class in our standard library, which is currently our only source of old IR for backward compatibility tests.
gzm0
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Unfortunately we don't have the infrastructure to test this in CI. @gzm0 Any suggestion?
I don't think there is anything we can do, lest we want to build the infrastructure to simulate old IR or publish some fake packages for testing specifically :-/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 1.11, the body of
JSConstructorDefs was a straight list of trees. We have a hack that extracts the three parts of a structuredJSConstructorBody:beforeSuper,superCallandafterSuper.In 1.18, we introduced a separate hack to ensure that
afterSuperstarts with aStoreModuleinstruction.Unfortunately, we did not apply the latter hack on the result of the former. This means our deserializer incorrectly reads JS module classes from before 1.11.
This commit makes sure to also apply the hack in that situation.
Unfortunately, this does not come with automated tests. We do not have any non-native JS module class in our standard library, which is currently our only source of old IR for backward compatibility tests.
Locally tested with the following hello world:
and the dependency
Unfortunately we don't have the infrastructure to test this in CI. @gzm0 Any suggestion?