Skip to content

Fix #5159: Register static module dependency on used lambda classes. #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Fix #5159: Register static module dependency on used lambda classes. #5160

merged 1 commit into from
Apr 28, 2025

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Apr 28, 2025

When we use a lambda class, we implicitly instantiate it. That constitutes a static dependency, which we previously failed to register.

@sjrd
Fix scala-js#5159: Register static module dependency on used lambda c…
1e6540a 
…lasses.

When we use a lambda class, we implicitly instantiate it. That
constitutes a static dependency, which we previously failed to
register.
@sjrd sjrd requested a review from gzm0 April 28, 2025 18:05
@sjrd sjrd merged commit 619202c into scala-js:main Apr 28, 2025
3 checks passed
@sjrd sjrd deleted the fix-crash-with-modules-no-optimizer branch April 28, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzm0 gzm0 gzm0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjrd @gzm0