Opt: Recognize non-nullabe RT long as subtype of LongType #5189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered while working on scala-js#5077. This allows to remove unnecessary unboxes and unlocks more inlining.
|
Full diff on the test suite: https://gist.github.com/gzm0/b6b7b064f0edadbd1b65af827957d9c9 (fast opt). |
|
@sjrd, a somewhat related question: With nullability in the IR typesystem, why are non-nullable boxed types not subtypes / equivalent to primitive types? |
|
It seems, this appears quite often in the diff: - var t$1 = $uJ(new $c_RTLong(lo$3, hi$4));
- var lo$4 = t$1.RTLong__f_lo;
- var hi$5 = t$1.RTLong__f_hi;That not only removes an unnecessary unbox but also an unnecessary allocation. |
They may have a different representation. A non-nullable |
sjrd
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while working on #5077. This allows to remove unnecessary unboxes and unlocks more inlining.