Wasm: Store the symbols of private JS fields on the JS side. #5220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They always have to be manipulated on the JS side: at declaration time in the custom JS helper that creates the JS class; and at usage site for selection. Therefore, it was wasteful to store them as Wasm globals, only to pass them to JS helpers every time. We now declare them as JS variables, and we directly use those JS variables from the JS class. For selection, we define a pair of getter/setter helpers for each private JS field. This should be more efficient than passing symbols from Wasm to a unique pair of `jsSelect`/`jsSelectSet` helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They always have to be manipulated on the JS side: at declaration time in the custom JS helper that creates the JS class; and at usage site for selection. Therefore, it was wasteful to store them as Wasm globals, only to pass them to JS helpers every time.
We now declare them as JS variables, and we directly use those JS variables from the JS class. For selection, we define a pair of getter/setter helpers for each private JS field. This should be more efficient than passing symbols from Wasm to a unique pair of
jsSelect/jsSelectSethelpers.