Skip to content

Move {. => dom}/src #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
japgolly opened this issue Sep 6, 2021 · 3 comments · Fixed by #612
Closed

Move {. => dom}/src #571

japgolly opened this issue Sep 6, 2021 · 3 comments · Fixed by #612
Assignees
@japgolly
Milestone
v2.0.0

Comments

@japgolly
Copy link
Contributor

japgolly commented Sep 6, 2021

Currently the root project is .root and dom is .. It should be . and dom respectively.
@japgolly japgolly added this to the v2.0.0 milestone Sep 6, 2021
@japgolly japgolly self-assigned this Sep 6, 2021
@japgolly
Copy link
Contributor Author

Doesn't matter, fine as is

@japgolly
Copy link
Contributor Author

Actually I should do this.

  1. Makes the project consistent within itself, and with most other projects
  2. A user who opens sbt and runs test would be surprised to find that there are other modules whose tests didn't run

@japgolly japgolly reopened this Oct 18, 2021
@japgolly
Copy link
Contributor Author

I'll do this quickly now while the PR queue is empty

japgolly added a commit that referenced this issue Oct 20, 2021
@japgolly
Move dom module source into its own directory
44ff6b1 
Closes #571
@japgolly japgolly mentioned this issue Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@japgolly japgolly

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Move dom module source into its own directory scala-js/scala-js-dom
1 participant
@japgolly