Skip to content

Mention that --turboshaft-wasm is Node.js 23.x.x only #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

natsukagami
Copy link
Contributor

This was removed as part of v8 13.x.x (changeset, discussion).

Node.js 24.0.0 includes this version of v8, so specifying --turboshaft-wasm will cause Node to exit with bad option: --turboshaft-wasm

This was removed as part of v8 13.x.x ([changeset](https://chromium-review.googlesource.com/c/v8/v8/+/6074953), [discussion](https://issues.chromium.org/issues/382509286)).

Node.js 24.0.0 includes this version of v8, so specifying `--turboshaft-wasm` will cause Node to exit with `bad option: --turboshaft-wasm`
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I knew they had turned it on by default, but I did not know they had actively made the flag error out at the same time 🙈

@sjrd sjrd merged commit ff12850 into scala-js:main May 14, 2025
1 check passed
@natsukagami natsukagami deleted the patch-1 branch May 14, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants