Skip to content

ResourceObject needs to have "id" property as an Option[String] #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvexiau opened this issue Jan 12, 2016 · 4 comments
Closed

ResourceObject needs to have "id" property as an Option[String] #20

jvexiau opened this issue Jan 12, 2016 · 4 comments
Labels
enhancement

Comments

@jvexiau
Copy link
Contributor

jvexiau commented Jan 12, 2016

Hi,

I'm trying to implement your nice library.
I have a problem when I want to create a resource.

in the specification id is not mandatory :
http://jsonapi.org/format/#document-resource-objects

Exception: The id member is not required when the resource object originates at the client and represents a new resource to be created on the server.

Thanks,

Jeremie
@zmeda
Copy link
Contributor

zmeda commented Jan 12, 2016

Hi Jeremie,

First of all thanks for showing the interest to the library.
We are aware of that and we will fix it in the next release. It was meant to be a part of issue #10 . But since there is a need for that we will fix it right away.

Best,
Boris

@jvexiau
Copy link
Contributor Author

jvexiau commented Jan 12, 2016

Hi Boris,
thanks for your quick reply,
I'm using your library with play 2.3 (thanks a lot for your last release 0.3.0 !!)

At this time, everything works fine.

best regards,

Jeremie

zmeda pushed a commit that referenced this issue Jan 12, 2016
Adds optional ID in the resource object.
0640e39 
Bumps the version.
Fixes #20.
@zmeda zmeda mentioned this issue Jan 12, 2016
Merged
@zmeda
Copy link
Contributor

zmeda commented Jan 12, 2016

We haven't fully tested integration with Play-JSON. Basically just with tests.
So any feedback would be more then appreciated. We are glad that it works fine now! 👍

PR will be soon merged and issue should be solved.

Best,
Boris

@zmeda zmeda closed this as completed in #21 Jan 12, 2016
@jvexiau
Copy link
Contributor Author

jvexiau commented Jan 12, 2016

Awsome !
thanks,

For the moment, we implement only simple resourceObject (no ResourceObjects) with some relations, links and meta.
Play Reader and Writer work fine !
we still have to implement errors. but i m sure it will be OK !

best regards,
Jeremie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zmeda @jvexiau