-
Notifications
You must be signed in to change notification settings - Fork 29
Support Play 2.5 #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this issue now "solved" by using proper dependencies and updated README? |
Just based on the changes in the documentation, this error still occurs on Play 2.5 apps. I was able to correct this problem locally (haven't yet pushed this change to my fork yet) by updating the scala-jsonapi build.sbt to use an up to date play-json depdendency:
However, I am not certain this is a backwards safe change, so it would lead me to think a major release increase would be needed. Another solution I thought of, still not necessarily backwards compatible from 0.5.0 , would be to break up the project to be more modular. Instead of depending on
|
Can you override the dependency by adding this to
|
I was also thinking of splitting this into more modular pieces, namely:
I tried to achieve this by having one repo (one project as it is now) and just using Please give feedback. |
Sorry for the very slow response. I was kinda dragged away from this. @nehalium I tried adding the line to my plugins.sbt and just get a dependency issue ( |
Does it support Play framework 2.5 or not? I thought already supported :-) |
@camuthig AFAIK, it is almost impossible to support multiple play-versions when depending on play libs, cause they have bc breaks between major versions (epoch.major.minor)... swagger-play e.g. did a subtree split and is copying code for each play version. Or you could bump up major version for play 2.5 (depends on versioning scheme). One solution, as @zmeda mentioned, would be to split play glue-code into a separate project and sync versioning with play-framework... |
@frne fyi, Play's versioning scheme is epoch.major.minor -- Play 2.5 is binary incompatible with Play 2.4. |
@wsargent Thx for clarification. That's what I meant... |
The current documented play-json version is causing errors with Play 2.5 applications.
The text was updated successfully, but these errors were encountered: