added AkkaHttpJsonapiSupport - Java 1.8 #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2016
|
I think the build fails because akka requires Java 1.8 |
|
akka version that supports java 1.7 is It's up to you to make a decision how to handle that, by my project uses Java 1.8 and akka 2.4.4 The PR I did is a ported version of the code we have in use internally |
|
In order to support akka-http (latest version) I had to drop support for Java 7 and move to Java 8, and also drop support for Scala 2.10 |
Current coverage is 92.96%@@ master #39 diff @@
==========================================
Files 9 10 +1
Lines 280 284 +4
Methods 280 284 +4
Messages 0 0
Branches 0 0
==========================================
Hits 264 264
- Misses 16 20 +4
Partials 0 0
|
| import akka.http.scaladsl.unmarshalling.{ FromEntityUnmarshaller, Unmarshaller } | ||
|
|
||
| trait AkkaHttpJsonapiSupport extends SprayJsonJsonapiFormat with DefaultJsonProtocol { | ||
| implicit def akkaHttpJsonJsonapiMarshaller(implicit printer: JsonPrinter = PrettyPrinter): ToEntityMarshaller[RootObject] = { |
There was a problem hiding this comment.
We are using following marshaller:
implicit def jsonApiMarshaller[T: JsonapiRootObjectWriter]: ToEntityMarshaller[T] =
Marshaller.withFixedContentType(jsonApiContentType) { obj =>
HttpEntity(`application/vnd.api+json`, obj.rootObject.toJson.compactPrint)
}
So I think it is better to use non-string marshaller (if possible). This is also generic one based on Writer.
|
@zmeda I addressed your points in my latest commit, it's in fact much better now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Akka Http Support - fixes #29