AkkaHttpJsonapiSupport - small fixes #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d be a StringMarshaller
Current coverage is 94.95%@@ master #56 diff @@
==========================================
Files 13 13
Lines 437 436 -1
Methods 437 436 -1
Messages 0 0
Branches 0 0
==========================================
Hits 414 414
+ Misses 23 22 -1
Partials 0 0
|
|
Can we somehow write test(s) for that? |
|
I think it's possible to add tests, this would require pulling in couple of additional dependencies for the |
|
I'm working on a more complete testing example (will create separate PR for this), it would be good to merge this in earlier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AkkaHttpJsonapiSupportakkaHttpJsonapiMarshallershould be a StringMarshaller - current approach somehow doesn't work (when behind nginx)Ready to review