Skip to content

Adding Object Links. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2016
Merged

Adding Object Links. #81

merged 4 commits into from
Dec 7, 2016

Conversation

prahim
Copy link

@prahim prahim commented Nov 23, 2016

Adding the ability to have json api object links that contain href & meta.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.07%) to 89.544% when pulling f905eda on prahim:master into d793788 on zalando:master.

@codecov-io
Copy link

codecov-io commented Nov 23, 2016

Current coverage is 95.97% (diff: 100%)

Merging #81 into master will increase coverage by 0.71%

@@             master        #81   diff @@
==========================================
  Files            17         17          
  Lines           464        547    +83   
  Methods         464        547    +83   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            442        525    +83   
  Misses           22         22          
  Partials          0          0          

Powered by Codecov. Last update d793788...41f13a5

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.07%) to 89.544% when pulling 07936bc on prahim:master into d793788 on zalando:master.

@zmeda
Copy link
Contributor

zmeda commented Nov 24, 2016

Is it possible to write more proper tests?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 95.247% when pulling 56a0663 on prahim:master into d793788 on zalando:master.

Copy link
Contributor

@zmeda zmeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please update versions.sbt and readme to be ready for next publish?

@prahim
Copy link
Author

prahim commented Dec 5, 2016

Requested changes made

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 95.247% when pulling 41f13a5 on prahim:master into d793788 on zalando:master.

@zmeda zmeda merged commit 5e588a0 into scala-jsonapi:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants