#64: Fixed some of test compile errors #84
Conversation
- Ensured that absolute imports are used for `spray.json` instead of relative imports possibly refering to org.zalando.jsonapi packages. - Updated missing dependency
| @@ -6,7 +6,7 @@ import akka.http.scaladsl.unmarshalling._ | |||
| import org.zalando.jsonapi.model._ | |||
| import org.zalando.jsonapi.sprayjson.SprayJsonJsonapiProtocol | |||
| import org.zalando.jsonapi.{JsonapiRootObjectReader, JsonapiRootObjectWriter, _} | |||
| import spray.json._ | |||
| import _root_.spray.json._ | |||
There was a problem hiding this comment.
I don't get it, why do we have to add it?
There was a problem hiding this comment.
You're right, it's not actually required to get sbt compile to work, but IntelliJ Idea thinks that we're refering to package org.zalando.jsonapi.spray.json which does not exist.
It's because on previous line there's include for import org.zalando.jsonapi._
Also this would work in both Idea and SBT
import org.zalando.jsonapi.{JsonapiRootObjectReader, JsonapiRootObjectWriter, ToJsonapiRootObjectWriterOps}
import spray.json._
There was a problem hiding this comment.
I should have understood to mention that I was also fixing errors in Idea by adding _root_ to some of the imports.
There was a problem hiding this comment.
Do we need to merge this PR first?
There was a problem hiding this comment.
I would take the approach of merging these changes as small individual pull requests to make it easier to review. This one should be independent of pull request #85 and can be merged at will :)
spray.jsoninstead of relativeimports possibly refering to org.zalando.jsonapi packages.
This change is