Issue #64 fix rest of compilation errors #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert the regression from merge 2bd6f42
- Move SprayJsonJsonapiSupport to spryjson package - Fix subproject dependencies in build.sbt - Fix infinite recursion in SprayJsonapiSupport - Delete SprayJsonapiSupportTest for now since it is a new feature and out of scope of the issue to be fixed. It can be created as a fix to a separate issue
Import implicit marshallers to the Spec
Import implicit marshallers to the Spec
oporkka
commented
Feb 25, 2017
| import spray.httpx.marshalling._ | ||
| import spray.httpx.unmarshalling._ | ||
|
|
||
| class SprayJsonapiSupportTest extends WordSpec with MustMatchers with TypeCheckedTripleEquals with EitherValues { |
There was a problem hiding this comment.
This did not compile but it was also introduced only as part of the initial issue #64 refactoring effort and does not exist in the current master branch. I propose that we reintroduce this test in another issue/pull request.
zmeda
approved these changes
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope of the issue to be fixed. It can be created as a fix to a separate
issue