Skip to content

2.12 circe #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

2.12 circe #93

wants to merge 5 commits into from

Conversation

emanresusername
Copy link
Contributor

@emanresusername emanresusername commented Apr 12, 2017 •
edited
Loading

This is more for discussion as it doesn't play nicely with the upstream in the current state.
Some of the goals here are

@emanresusername emanresusername force-pushed the 2.12-circe branch 5 times, most recently from b80341e to 05f217b Compare April 13, 2017 21:45
@lasomethingsomething
Copy link

lasomethingsomething commented Apr 25, 2017 •
edited
Loading

@oporkka Have you acknowledged this PR by @emanresusername elsewhere? Wondering what the plan is.

@oporkka
Copy link
Collaborator

oporkka commented Apr 26, 2017

I think this should adapt to the world of https://github.com/zalando/scala-jsonapi/issues/64 which has separate jars for the support of different libraries

@emanresusername
Copy link
Contributor Author

yeah, so the way i was looking at it is this is basically the code that would ultimately produce the jars for the scala-jsonapi-core (could combine with implicits) and scala-jsonapi-circe modules discussed in that issue
with the caveat that neither spray nor akka-http nor marshalling of any sort would be considered core to this project anymore. and this project would just focus on implementing the jsonapi spec case classes and getting them to<->from json representations
does that make sense?

@emanresusername emanresusername mentioned this pull request Jul 6, 2017
Closed
@oporkka oporkka mentioned this pull request Jan 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emanresusername @lasomethingsomething @oporkka