Skip to content

Allow null as value to represent no values for optionals in spray-json formatter #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

alanwguo
Copy link
Contributor

@alanwguo alanwguo commented Jun 24, 2017

closes #94

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 95.878% when pulling 3d34df6 on alanwguo:master into 1857ff3 on zalando:master.

@codecov-io
Copy link

codecov-io commented Jun 24, 2017

Codecov Report

Merging #95 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   96.58%   96.59%   +<.01%     
==========================================
  Files          17       17              
  Lines         557      558       +1     
==========================================
+ Hits          538      539       +1     
  Misses         19       19
Impacted Files Coverage Δ
.../jsonapi/json/sprayjson/SprayJsonReadSupport.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1857ff3...3d34df6. Read the comment docs.

Copy link
Collaborator

@oporkka oporkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@oporkka
Copy link
Collaborator

oporkka commented Jun 29, 2017

@zmeda what do you think?

@oporkka oporkka merged commit 0c83087 into scala-jsonapi:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for null relationships
4 participants