Skip to content

Commit 7bee26b

Browse files
committed
TST remove testing if approx_hessian=True
1 parent a5c1d3c commit 7bee26b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

sklearn/_loss/tests/test_loss.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,8 @@ def grad_func(x):
609609

610610
h_numeric = numerical_derivative(grad_func, raw_prediction, eps=1e-6)
611611
if loss.approx_hessian:
612-
assert np.all(h >= h_numeric)
612+
# TODO: What could we test if loss.approx_hessian?
613+
pass
613614
else:
614615
assert_allclose(h, h_numeric, rtol=5e-6, atol=1e-10)
615616
else:
@@ -643,7 +644,8 @@ def grad_func(x):
643644

644645
h_numeric = numerical_derivative(grad_func, raw_prediction[:, k], eps=1e-6)
645646
if loss.approx_hessian:
646-
assert np.all(h >= h_numeric)
647+
# TODO: What could we test if loss.approx_hessian?
648+
pass
647649
else:
648650
assert_allclose(h[:, k], h_numeric, rtol=5e-6, atol=1e-10)
649651

0 commit comments

Comments
 (0)