Replies: 2 comments
-
|
The reason is that this part of the code is private so there is no guarantee that it will not break between 2 versions. |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Fair enough! Thanks for the clarification! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
ba46b65 renamed
sklearn.utils._param_validation._MissingValuestosklearn.utils._param_validation.MissingValues. This change in version 1.3.0 breaks other libraries likeiambalanced-learnsee scikit-learn-contrib/imbalanced-learn#996. So my question is whether the name change was on purpose and the breaking libraries should be updated accordingly or if this was just an honest mistake and the name should not have been changed.Beta Was this translation helpful? Give feedback.
All reactions