Extra computation performed by sklearn.isotonic.check_increasing #31023
zhaoxiaofei
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
It seems that the following line has an extra math.tanh operation performed when it is not needed because tanh does not change the sign of its operand anyway.
The relevant code is here:
https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/isotonic.py#L87
The context of the code is as follow:
Beta Was this translation helpful? Give feedback.
All reactions